-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Catalan translation #2333
Add Catalan translation #2333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! I have some comments. I hope it will be merged.
|
||
#: build-home-citation.R:91 | ||
msgid "Authors and Citation" | ||
msgstr "Autors i citació" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use "Autors i cita" or even "Autors i referències"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
«cita» doesn't seem to have the proper meaning acoording to (dlc). «referències» could work as well as «citació» but should be in singular as it refers to the documented package only. In this case, I would leave the PR's original text.
Many thanks for your review, @llrs! I applied all your comments except for «Autors i citació». If you agree with the final result, we can merge It's a pleasure to be able to comment on Catalan translations with others 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Thanks for working on this translation everyone! |
Thank you for taking the time @hadley 🙏 |
No description provided.