-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit to CRAN #46
Comments
Sorry to leave this hanging for two days...I'm totally fine with a CRAN submission but I think there are a few issues that need to be addressed before any particular release (of qgisprocess) can be considered "stable". That said, I think maintaining this particular CRAN package will not be hard because it can't run any actual tests (because QGIS is not installed). I think I'd still prefer users to install this via Happy to debate this list, but in my head these are the things that need to happen before there is any particular release of qgisprocess that can be considered "stable":
|
Apologies for the slow response to me. I discussed this issue yesterday with @jannes-m and @Nowosad in relation to the 2nd edition of Geocomputation with R, which we plan to publish at some point in 2022, likely spring or summer, and it would be great if the package were on CRAN by then. Good news: we're happy to help with that effort although unsure which bits you need help with. Regarding your list, I guess the file paths one is the most important. The others I would see as 'nice to have'. My thinking is that having it on CRAN will open up this amazing package to a wide range of people and therefore encourage further development. Agree #36 looks like a big one... |
I agree that this should happen soon...I'm giving a talk on this at FOSS4G and I think that will be a good time to get a round of feedback, after which a CRAN submission seems in order. One thing I didn't realize is that there is no way to use JSON as input yet. I flagged Nyall already, but this feature is important for getting things to work smoothly on Windows and to support all the input types. That said, I think I can fix the WKT2 thing by working around the .bat file (and will do so before FOSS4G). I'd also like to properly use the JSON output before FOSS4G since it's now available in almost everybody's installed QGIS version. Something that would help me out would be to generate a bunch of minimal test cases for all the input types. Like...find simple algorithms that have an input type and write a |
That definitely sounds like something I can can help with and I imagine Jannes will be keen to get involved in the effort too. Worth creating a separate issue on it? Happy to be assigned on that. |
Use #13! |
I am happy to help, of course! But before doing so, I plan to finally finish writing the vignette(s) (#31). I plan to do so within the next 2 to 3 weeks. |
Updating Dewey's checklist:
I'm not sure where we are with #13, but to be checked further; probably supporting JSON-input-only for some cases, and preferably tests are added to check the support for different QGIS inputs. Proposing remaining steps wrt CRAN submission:
|
Dewey and I had a brief meeting today.
As always, further ideas are most welcome! |
I'm in the stage of anticipating CRAN notes before submitting, based mainly on advice in r-pkgs.org & usethis. @paleolimbot @JanCaha @jannes-m for CRAN submission we should add a copyright holder ( Consequently, INBO is also package funder ( |
Sure, no problem ;) |
Yeah, go for it. |
Go for it! No need to add my employer as a copyright holder. |
Great, thanks for the quick responses. |
BTW, I have also included affiliations in DESCRIPTION for Dewey (Voltron Data) and myself. Lines 5 to 8 in c9c9f4c
If I should add this for more people, let me know! Affiliations appear in CITATION.cff on GitHub and also in the foreseen Zenodo publication, when hovering above the author names (example). |
Amazing! |
This package is very, very useful. Yet it is not very visible to users. I think getting on CRAN will make it way more useful. The fact it has external dependencies that may not be installed on CRAN servers should not be a barrier, as outlined here: r-spatial/discuss#41 (comment)
I'm happy to run some tests to see what happens after running
will also help us with our work updating Geocomputation with R to use more modern and effective packages.
The text was updated successfully, but these errors were encountered: