edit revisions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edzer
pushed a commit
that referenced
this pull request
Sep 26, 2018
checks and cleanup for ExecuteSQL
djhshih
added a commit
to djhshih/sf
that referenced
this pull request
Aug 8, 2024
R
> devtools::install()
Compilation error encountered with gcc 4.2:
```
In file included from gdal.cpp:1:
./gdal.h:3:1: error: ‘OGRSpatialReference’ does not name a type; did you mean ‘DEFINED_OGRSpatialReferenc
eH’?
3 | OGRSpatialReference *handle_axis_order(OGRSpatialReference *sr);
| ^~~~~~~~~~~~~~~~~~~
| DEFINED_OGRSpatialReferenceH
./gdal.h:4:1: error: ‘Rcpp’ does not name a type
4 | Rcpp::List create_crs(const OGRSpatialReference *ref, bool set_input);
| ^~~~
```
This commit forward declares `OGRSpatialReference` to fix the first
error above, and it includes `Rcpp.h` explicitly to fix the second
error.
```
$ R --version
R version 4.4.1 (2024-06-14) -- "Race for Your Life"
$ gcc --version
gcc (GCC) 14.2.1 20240802
$ uname -a
Linux durus 6.10.3-arch1-1 r-spatial#1 SMP PREEMPT_DYNAMIC Sun, 04 Aug 2024 05:11:32 +0000 x86_64 GNU/Linux
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some clarification, some links