Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you consider your package to be included in GNU ELPA? #225

Closed
gnusupport opened this issue Nov 6, 2020 · 13 comments
Closed

Could you consider your package to be included in GNU ELPA? #225

gnusupport opened this issue Nov 6, 2020 · 13 comments

Comments

@gnusupport
Copy link

Please let me know if you could consider including your package in GNU ELPA, so that it becomes generally available to Emacs users by default?

That would involve all developers to sign some papers. Other GNU ELPA packages could then build upon this package.

@gnusupport gnusupport changed the title Could you include your package to be included in GNU ELPA? Could you consider your package to be included in GNU ELPA? Nov 6, 2020
@raxod502
Copy link
Member

raxod502 commented Nov 7, 2020

I have no problem with Selectrum being added to GNU ELPA. However, I am unwilling to assign my copyright for Selectrum, nor am I willing to collect such copyright assignments from my contributors. Therefore, inclusion would be subject to a change of policy on your end.

The same judgment applies to all of my other open-source work.

@raxod502 raxod502 added the waiting on response Needs more info or follow-up, will be closed after 90 days if no response label Nov 7, 2020
@raxod502
Copy link
Member

raxod502 commented Nov 7, 2020

My projects may be better candidates for inclusion in the so-called "Non-GNU ELPA" project that I hear is being created, although I am not familiar with the details.

@gnusupport
Copy link
Author

gnusupport commented Nov 7, 2020 via email

@gnusupport
Copy link
Author

gnusupport commented Nov 7, 2020 via email

@raxod502
Copy link
Member

raxod502 commented Nov 8, 2020

Sounds good! I understand your point of view, it definitely is nice when packages are more easily accessible.

@raxod502 raxod502 closed this as completed Nov 8, 2020
@raxod502 raxod502 removed the waiting on response Needs more info or follow-up, will be closed after 90 days if no response label Nov 8, 2020
@minad
Copy link
Contributor

minad commented Nov 8, 2020

@gnusupport While I also would like to see selectrum being used more widely, I am not sure if moving to closure upstream is a necessary requirement here. What I find more important is that the APIs offered by Emacs are made as such that packages like this work well and continue to do so. I am not sure if there is anything which needs to be done - but there seems to be quite some complexity around the completion framework. There is ido which appears in many places in the emacs code base, but does not integrate well with the completion framework. And selectrum seems to hook into quite a few places, maybe there are some warts which could be sorted out. For another example, when I recently tried multi-occur, it didn't work nicely with selectrum, since multi-occur uses the wrong apis internally (see #226). So I think these are the points where downstream projects like this matter a lot and could contribute back to upstream. Maybe @raxod502 would also be willing to contribute to that with his experiences - in contrast to giving up copyright, which I too find a questionable requirement.

@gnusupport
Copy link
Author

gnusupport commented Nov 8, 2020 via email

@minad
Copy link
Contributor

minad commented Nov 8, 2020

@gnusupport I am not involved with this project. In case you misunderstood this. I am as external to this project as you.

I also prefer the more limited scope of selectrum to something like ivy or helm. While I like many of the ideas promoted by those projects, I don't like that they change everything.

But I don't agree that things should move into upstream or necessarily have to move closer to upstream. I would rather advocate for removal of stuff from Emacs core, moving it to Elpa. Instead the focus should be on extensible APIs in the core. Basically my point is that there shouldn't be some package with first class status, like icomplete and ido, instead all of the completion packages should have the same standing.

@gnusupport
Copy link
Author

gnusupport commented Nov 8, 2020 via email

@minad
Copy link
Contributor

minad commented Nov 8, 2020

There is no first class status especially not for ido or
icomplete. How you get that impression?

There is. For example if you look around in the emacs codebase, at some places there are special cases for ido. Icomplete does not really have first class support, except for being part of upstream. My point is more that things like this should be avoided, if things are already good, I am happy!

@gnusupport
Copy link
Author

gnusupport commented Nov 8, 2020 via email

@raxod502
Copy link
Member

my point is that there shouldn't be some package with first class status, like icomplete and ido,

Yeah, this gets a big +1 from me. Special cases in Emacs core for third-party packages is one of the bigger ecosystem problems. It seems like within Emacs core, there is no concept of modularity or separation of concerns: if a package is supported in Emacs core, it's just kind of a part of everything, instead of being a separate part that could be included or excluded freely. Ido and Icomplete are indeed some of the worst offenders. Isearch has a lot of random hooks throughout core, and perhaps the most egregious case is ElDoc, which has extensive explicit support for Company-specific features despite Company not even being a part of Emacs core (see elisp-mode.el.gz in the distribution)!

If the upstream developers spent some time to develop better interfaces, these kinds of hacks would not be needed.

@gnusupport
Copy link
Author

gnusupport commented Nov 15, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants