Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter t.join error #300

Closed
jlaura opened this issue Apr 10, 2023 · 3 comments
Closed

Filter t.join error #300

jlaura opened this issue Apr 10, 2023 · 3 comments
Milestone

Comments

@jlaura
Copy link
Contributor

jlaura commented Apr 10, 2023

I just upgraded to v3.0.0 (thanks for the release!). I am testing filters on the API endpoint that we run and am seeing 'loading a filtered list of items failed' with a cause of t.join is not a function. Is this because the stac-server that is providing the API does not support the filters, or is this me misconfiguring something?

Please feel free to play around with this at: https://stac.astrogeology.usgs.gov/browser-dev/#/collections/mro_hirise_uncontrolled_observations.

Screen Shot 2023-04-10 at 3 10 49 PM

@m-mohr
Copy link
Collaborator

m-mohr commented Apr 11, 2023

One of the issues is that the bbox provided in the Collection is invalid, it's not WGS84. Thus it can't properly handle selecting the spatial extent. It looks like this is the root cause, but STAC Browser also doesn't handle it very gracefully, so I'll try to improve it.

m-mohr added a commit that referenced this issue Apr 11, 2023
@m-mohr
Copy link
Collaborator

m-mohr commented Apr 11, 2023

The last commit should improve the situation for you. The bbox in the collection is still invalid, but the spatial extent filter is now working as expected also when the given extent in the collection is invalid and using the non-Earth WMS baselayers. Let me know if you still encounter any errors. Thanks.

@m-mohr m-mohr closed this as completed Apr 11, 2023
@m-mohr m-mohr modified the milestones: 3.0.0, 3.1.0 Apr 11, 2023
@jlaura
Copy link
Contributor Author

jlaura commented Apr 12, 2023

@m-mohr Thanks! I got the BBoxes fixed on the collections as well. These are rendering now in v3.0.0. I'll pull and deploy this PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants