Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3:// links always titled as "Amazon S3" #408

Closed
m-mohr opened this issue Feb 23, 2024 · 1 comment
Closed

s3:// links always titled as "Amazon S3" #408

m-mohr opened this issue Feb 23, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone
3.2.0

Comments

@m-mohr
Copy link
Collaborator

m-mohr commented Feb 23, 2024

It would be great if that's configurable and can be detected based on the host name.
@m-mohr m-mohr added the enhancement New feature or request label Feb 23, 2024
@m-mohr m-mohr added this to the 3.1.1 milestone Feb 23, 2024
m-mohr added a commit that referenced this issue Feb 23, 2024
@m-mohr
s3:// links not always titled as being from "Amazon". Defaults to S3,…
60855dc 
… can be customized via language file. #408
@m-mohr
Copy link
Collaborator Author

m-mohr commented Feb 23, 2024 •
edited
Loading

This defaults to S3 now, can be customized based on the domain name in the language pack.

Example:

  "protocol": {
    ...
    "s3": {
      "default": "S3",
      "amazonaws.com": "Amazon S3",
      "eodata": "CDSE S3"
    }
  },

@m-mohr m-mohr closed this as completed Feb 23, 2024
@m-mohr m-mohr modified the milestones: 3.1.1, 3.2.0 Mar 7, 2024
silvester-pari pushed a commit to EOEPCA/open-science-catalog-stac-browser that referenced this issue May 29, 2024
@m-mohr @silvester-pari
s3:// links not always titled as being from "Amazon". Defaults to S3,…
e452c07 
… can be customized via language file. radiantearth#408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
1 participant
@m-mohr