Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese locale #417

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Add Japanese locale #417

merged 2 commits into from
Mar 21, 2024

Conversation

tmokmss
Copy link
Contributor

@tmokmss tmokmss commented Mar 21, 2024

Let me add Japanese locale 🙏
Though it hasn't been finished yet, I think crowdin platform will help more collaboration.

@tmokmss tmokmss requested a review from m-mohr as a code owner March 21, 2024 01:25
@m-mohr m-mohr merged commit 587304a into radiantearth:main Mar 21, 2024
@m-mohr
Copy link
Collaborator

m-mohr commented Mar 21, 2024

Great, thank you @tmokmss. Looking forward to the Japan locales.
Could you please register at https://crowdin.com/project/stac-browser/ and let me know your username so that I can invite you? Thanks.

@tmokmss
Copy link
Contributor Author

tmokmss commented Mar 21, 2024

@m-mohr I guess I successfully joined the project (username: tmokmss) :) Thanks!

@tmokmss tmokmss deleted the add_ja_locale branch March 21, 2024 14:57
@m-mohr
Copy link
Collaborator

m-mohr commented Mar 21, 2024

Great! You should've permission now to translate into Japanese. Looking forward to it. If you get to > 75% in the next one or two weeks, I can incluide it in STAC Browser 3.2.0. Otherwise we'll just enable Japanese later.

@tmokmss
Copy link
Contributor Author

tmokmss commented Mar 26, 2024

@m-mohr Coverage is now above 90% for texts.json 🚀
image

As for fields.json it is difficult to translate without context so I'll leave it for now. Most of them are simple words so I guess it shouldn't be a huge problem.

@m-mohr
Copy link
Collaborator

m-mohr commented Mar 26, 2024

@tmokmss Great work, thanks!

I can give you some context on the fields.json: This file is responsible for translating the metadata rendering, mostly the labels and values for the individual metadata fields and the extension names. So basically this part:

grafik

Most of the phrases translate what is in this file: https://github.com/stac-utils/stac-fields/blob/main/fields.json
There you can see which extension the phrases belong to. For example the phrase "Snow/Ice Cover" belongs to the STAC field eo:snow_cover from the EO extension and it is the label for the value that is provided in %.

Many fields in the file are indeed names which can often be kept as is, but some would be very valuable, I think. Expecially for the common extensions and the core metadata. So I'd highly appreciate if you could also take a closer look at the fields.json.

silvester-pari pushed a commit to EOEPCA/open-science-catalog-stac-browser that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants