Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container property should both describe and set port #6647

Open
willtsai opened this issue Nov 3, 2023 · 2 comments
Open

Container property should both describe and set port #6647

willtsai opened this issue Nov 3, 2023 · 2 comments
Labels
feature This issue describes a feature request in Radius triaged This issue has been reviewed and triaged

Comments

@willtsai
Copy link
Contributor

willtsai commented Nov 3, 2023

Overview of feature request

Currently, the Applications.Core/containers.properties.container.ports property is being used to describe or document the port that is exposed by the container to serve incoming traffic. This has potential to be confusing for users who might expect that this property actually sets the port (and not just describe/document) that is exposed or forwarded by the container.

Thus, the proposal here is to change the behavior of the Applications.Core/containers.properties.ports property to explicitly override or set the port that is exposed by the container, in addition to documenting the port.

Acceptance criteria

When the user specifies the Applications.Core/containers.properties.container.ports, an override is created for the container to expose the user specified port instead of the port originally offered by the container.

Additional context

This request originated from PR radius-project/samples#748 to address radius-project/docs#916, where there was some confusion regarding which port the container ends up offering when the Applications.Core/containers.properties.container.ports differs from the originally offered port in the container.

Will need to explore how to accomplish the override, which might differ by app framework, e.g. for .NET apps, the port override can be provided as an env variable - https://learn.microsoft.com/en-us/aspnet/core/fundamentals/host/web-host?view=aspnetcore-3.1#server-urls-2

AB#10034

@willtsai willtsai added the feature This issue describes a feature request in Radius label Nov 3, 2023
@radius-triage-bot
Copy link

👋 @willtsai Thanks for filing this feature request.

A project maintainer will review this feature request and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@shalabhms shalabhms added the triaged This issue has been reviewed and triaged label Nov 6, 2023
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue describes a feature request in Radius triaged This issue has been reviewed and triaged
Projects
None yet
Development

No branches or pull requests

2 participants