[WIP] Update for timeout issue for playwright test errors #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakshmimsft
changed the title
lakshmimsft
force-pushed
the
lakshmimsft/timeoutissue
branch
3 times, most recently
from
05e38f9
to
acc56ec
Compare
lakshmimsft
changed the title
lakshmimsft
force-pushed
the
lakshmimsft/timeoutissue
branch
5 times, most recently
from
609054e
to
e1d13d6
Compare
ytimocin
reviewed
Jul 13, 2024
Comment on lines
+269
to
+275
| - name: Wait for all pods to be ready | ||
| if: steps.gen-id.outputs.RUN_TEST == 'true' | ||
| id: wait-for-pods | ||
| run: | | ||
| namespace="${{ matrix.env }}-${{ matrix.app }}" | ||
| label="radapp.io/application=${{ matrix.app }}" | ||
| kubectl rollout status deployment -l $label -n $namespace --timeout=90s |
There was a problem hiding this comment.
We don't need this because rad deploy already waits for all pods to be ready. We discussed this with @rynowak.
There was a problem hiding this comment.
Ideally we don't need this 😉. If we're inserting waits in random places it can mask bugs.
There was a problem hiding this comment.
yes, i had seen the comment in an earlier PR where this isn't needed. I was curious what the output of this would be now since the endpoint isn't currently loading. no intention to merge this in.
lakshmimsft
force-pushed
the
lakshmimsft/timeoutissue
branch
from
e1d13d6
to
1598336
Compare
|
closing this for now. so, far determined that it's not a timeout issue. endpoint is not reachable. local debugging is needed for further debugging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(We can run this on the pipeline to see it's effects, if not helpful, we can revert it back).
Fixes: #1592