-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radix Dialog - Events for open and close separately #1678
Comments
Hi @varun-raj, What would be the advantage of this? The current API achieves everything without bloating the API surface. |
Closing this issue due to lack of activity, feel free to follow up with more information about the request though. |
@andy-hook it seems like the onOpenChange prop is inactive for open event. i am using this version |
@TimHuynh0905 what do you mean? Do you have an example sandbox? |
@benoitgrelard I'm facing the same issue, onOpenChange does not seem to be triggered when open property is switching from false to true. Here is our usage of the dialog: |
@charlesBochet |
mmmh ok, thanks for the answer! |
@varun-raj i dont know if this help or not but the onOpenChange function has boolean inside of it which radix hasnt mention which tells you about whether the event is open or close |
Can we have separate events to trigger for onOpen and onClose in a modal?
Currently we've the
onOpenChange
for radix dialog that triggers whenever the dialog opens or closes. Can we bring a way to have individual events for open and close?I've a logic for it already, if its required, I can raise a PR
The text was updated successfully, but these errors were encountered: