Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer, I want linters to run automatically before git push #1786

Open
3 of 8 tasks
andrew-jameson opened this issue May 13, 2022 · 3 comments · May be fixed by #3273
Open
3 of 8 tasks

As a developer, I want linters to run automatically before git push #1786

andrew-jameson opened this issue May 13, 2022 · 3 comments · May be fixed by #3273
Assignees
Labels
dev devops DX Developer Experience P1 Low Priority - Nice to Have Refined Ticket has been refined at the backlog refinement

Comments

@andrew-jameson
Copy link
Collaborator

andrew-jameson commented May 13, 2022

Description:
Provide a brief background and justification for this issue
Using git's pre-commit checks, ensure linters are auto-run before commit/push cycle.

Acceptance Criteria:
Create a list of functional outcomes that must be achieved to complete this issue

  • Allow linting errors in commits for but not pushes.
  • Configuration document for developers is produced
  • Secrets checks run before commits are allowed
  • Testing Checklist has been run and all tests pass
  • README is updated, if necessary

Tasks:
Create a list of granular, specific work items that must be completed to deliver the desired outcomes of this issue

  • Investigate git commit/push file actions
  • Investigate git secrets catches sendgrid api per recent events
  • Run Testing Checklist and confirm all tests pass

Notes:
Add additional useful information, such as related issues and functionality that isn't covered by this specific issue, and other considerations that will be helpful for anyone reading this

Supporting Documentation:
Please include any relevant log snippets/files/screen shots

Open Questions:
Please include any questions or decisions that must be made before beginning work or to confidently call this issue complete

@andrew-jameson andrew-jameson added dev DX Developer Experience labels May 13, 2022
@andrew-jameson andrew-jameson changed the title [DRAFT] As a developer, I want linters to run before git push As a developer, I want linters to automatically run before git push May 31, 2022
@andrew-jameson andrew-jameson changed the title As a developer, I want linters to automatically run before git push As a developer, I want linters to run automatically before git push May 31, 2022
@stevenino stevenino added the Refined Ticket has been refined at the backlog refinement label Jun 27, 2022
@robgendron robgendron added Old and removed Refined Ticket has been refined at the backlog refinement labels Apr 11, 2024
@robgendron
Copy link

Prioritize for after Parity.

@robgendron robgendron removed the Old label Apr 16, 2024
@robgendron robgendron added the Refined Ticket has been refined at the backlog refinement label Jun 4, 2024
@robgendron robgendron added the P1 Low Priority - Nice to Have label Jul 30, 2024
@andrew-jameson andrew-jameson self-assigned this Nov 6, 2024
@andrew-jameson andrew-jameson linked a pull request Nov 7, 2024 that will close this issue
28 tasks
@lhuxraft
Copy link
Collaborator

11/13/2024: Resolved git secrets, may show during office hours. Digging into truffle hog

@lhuxraft
Copy link
Collaborator

11/15: Continuing to look into truffle hog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev devops DX Developer Experience P1 Low Priority - Nice to Have Refined Ticket has been refined at the backlog refinement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants