We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Due to some Hash160 so-called collisions we cant use checkValueSent function. For example, we can have two BTC addresses that both have the same Hash 160, for instance: https://blockchain.info/ru/address/17AXqoGmJ71Noc2hZvDnP1wGPZTVykXsPd https://blockchain.info/ru/address/37rYmLmCr1Kktmj8h1tNoeJCY5kDaGHpjp
checkValueSent
My proposition is that we need to add another argument to specify the type of BTC address (p2p, p2sh or both).
Here we need to check specifically for our type of an address. https://github.com/rainbreak/solidity-btc-parser/blob/master/src/btc_tx.sol#L286
The text was updated successfully, but these errors were encountered:
Thanks for catching this! I won't have time to make a fix any time soon, but if anyone wants to propose a patch thatd be great.
Sorry, something went wrong.
No branches or pull requests
Due to some Hash160 so-called collisions we cant use
checkValueSent
function.For example, we can have two BTC addresses that both have the same Hash 160, for instance:
https://blockchain.info/ru/address/17AXqoGmJ71Noc2hZvDnP1wGPZTVykXsPd
https://blockchain.info/ru/address/37rYmLmCr1Kktmj8h1tNoeJCY5kDaGHpjp
My proposition is that we need to add another argument to specify the type of BTC address (p2p, p2sh or both).
Here we need to check specifically for our type of an address.
https://github.com/rainbreak/solidity-btc-parser/blob/master/src/btc_tx.sol#L286
The text was updated successfully, but these errors were encountered: