Add the README file by translating it into Korean. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using modal to refer to modal window https://en.wikipedia.org/wiki/Modal_window. As far as your pull request, I think it's really cool ! :) But it does not make sense to append the korean translation to the bottom of the english readme. If you moved the translation to a Readme_kr.md file and then linked to that file from the english readme that would be something I'd pull in. |
|
First of all, thank you very much. It's not enough, but I'd appreciate it if you could check it one more time!!!!!!
-----Original Message-----
From: "Rainer Oviir"<[email protected]>
To: "raineroviir/react-redux-socketio-chat"<[email protected]>;
Cc: "beom-i"<[email protected]>; "Author"<[email protected]>;
Sent: 2019-12-20 (금) 06:59:48 (GMT+09:00)
Subject: Re: [raineroviir/react-redux-socketio-chat] Add the README file by translating it into Korean. (#66)
Is mdal correct in line 56 of README? not model?
I'm using modal to refer to modal window https://en.wikipedia.org/wiki/Modal_window.
As far as your pull request, I think it's really cool ! :) But it does not make sense to append the korean translation to the bottom of the english readme. If you moved the translation to a Readme_kr.md file and then linked to that file from the english readme that would be something I'd pull in.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And I have a question about your README file.
Is mdal correct in line 56 of README? not model?
And plz take my pull request if you need it. Thanks...!