Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NASM bug #92

Open
FunkyFr3sh opened this issue Apr 17, 2024 · 1 comment
Open

NASM bug #92

FunkyFr3sh opened this issue Apr 17, 2024 · 1 comment

Comments

@FunkyFr3sh
Copy link

FunkyFr3sh commented Apr 17, 2024 •
edited
Loading

When one of the source files is built via NASM cv2pdb fails to remove the COFF_SYMBOLS from the built executable.

I tried to create a minimal version to reproduce the bug, it should build fine with w64devkit:
nasm.zip
no-nasm.zip

test exe (before cv2pdb):
test1.exe.zip

Without NASM source file
Before cv2pdb:
image

After cv2pdb:
image

With NASM source file
Before cv2pdb:
image

After cv2pdb:
image
@FunkyFr3sh
Copy link
Author

Actually, this bug is not related to NASM at all. It's related to the .patch section that is being added. Luckily in this case the section is only a temporary one and can be removed via objcopy .

Not sure if any changes are needed to cv2pdb to maybe improve the compatibility with such corner cases? I'll keep the issue open for now though. For me the problem is solved, feel free to close the issue if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FunkyFr3sh