Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supportfor typed property. #177

Open
Legion112 opened this issue Feb 18, 2022 · 4 comments
Open

Supportfor typed property. #177

Legion112 opened this issue Feb 18, 2022 · 4 comments

Comments

@Legion112
Copy link

Legion112 commented Feb 18, 2022

Mapping configuration via typed property

Remove @Orm\Columm(type="uuid") to minimize effort on configuration.

Background/problem

Redundant info of typed property and annotation.
image

Proposal/solution

Doctrine support getting type from typed property like so:
image

Alternatives

Additional context

This is an optional way to configure the mapping

@ramsey
Copy link
Owner

ramsey commented Dec 20, 2022

I don't understand the request for this enhancement. Should this lead to a change in the library code, or is this something that needs to be added to the examples in the README?

@Legion112
Copy link
Author

Legion112 commented Dec 21, 2022

I think it was clear that with PHP 7.4 classes have a typed property and you don't need to define type imperativly as it might be extracted from the type.

This have to be supported in this library.

https://www.doctrine-project.org/projects/doctrine-orm/en/2.13/reference/basic-mapping.html#doctrine-mapping-types

@ramsey
Copy link
Owner

ramsey commented Dec 21, 2022

What change are you requesting for ramsey/uuid-doctrine?

@zjbarg
Copy link

zjbarg commented Aug 5, 2023

@Legion112 string id column need not be UUID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants