Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external etcd connection #6355

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

vitorsavian
Copy link
Member

Proposed Changes

  • A bugfix for when the user uses datastore endpoint with etcd endpoints

Types of Changes

  • Bugfix

Verification

  • Run rke2 with a external etcd instance

Testing

Linked Issues

User-Facing Change


Further Comments

@vitorsavian vitorsavian requested a review from a team as a code owner July 17, 2024 02:44
Signed-off-by: Vitor Savian <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 25.25%. Comparing base (b704157) to head (5452dcb).
Report is 76 commits behind head on master.

Files with missing lines Patch % Lines
pkg/rke2/rke2_linux.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6355      +/-   ##
==========================================
+ Coverage   25.23%   25.25%   +0.01%     
==========================================
  Files          33       33              
  Lines        2829     2831       +2     
==========================================
+ Hits          714      715       +1     
- Misses       2068     2070       +2     
+ Partials       47       46       -1     
Flag Coverage Δ
inttests 9.64% <0.00%> (-0.01%) ⬇️
unittests 17.80% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitorsavian vitorsavian requested a review from a team July 17, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants