Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kill all script to not delete data dir #6558

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

vitorsavian
Copy link
Member

@vitorsavian vitorsavian commented Aug 13, 2024

Proposed Changes

Types of Changes

  • Bugfix

Verification

  • Install rke2 and mount the server folder with
mount --bin /var/lib/rancher/rke2/server /var/lib/rancher/rke2/server

and then use the kill all script

rke2-killall.sh

Testing

Linked Issues

User-Facing Change


Further Comments

Add tests to kill all script

Signed-off-by: Vitor Savian <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.18%. Comparing base (db057b8) to head (587fb7f).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6558      +/-   ##
==========================================
- Coverage   25.25%   25.18%   -0.08%     
==========================================
  Files          33       33              
  Lines        2831     2831              
==========================================
- Hits          715      713       -2     
- Misses       2070     2071       +1     
- Partials       46       47       +1     
Flag Coverage Δ
inttests 9.57% <ø> (-0.08%) ⬇️
unittests 17.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitorsavian vitorsavian merged commit 613399e into rancher:master Aug 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants