Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Make cfgparam an array #13

Open
shabazzfsher opened this issue Feb 16, 2024 · 3 comments
Open

[RFE] Make cfgparam an array #13

shabazzfsher opened this issue Feb 16, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@shabazzfsher
Copy link

shabazzfsher commented Feb 16, 2024

#Feature Request

Request description:
Customer requests that cfgparam should be structured as an array.

Example:
apiVersion: rke-machine-config.cattle.io/v1
kind: VmwarevsphereConfig
metadata:
  name: nc-vsphere-master-config
  namespace: fleet-default
network:
- /Example/VM-Network
os: linux
cfgparam:
- disk.enableUUID=TRUE
@bcdurden
Copy link

bcdurden commented Apr 3, 2024

It is already an array:

>kubectl explain VmwarevsphereConfig.cfgparam
GROUP:      rke-machine-config.cattle.io
KIND:       VmwarevsphereConfig
VERSION:    v1

FIELD: cfgparam <[]string>

DESCRIPTION:
    vSphere vm configuration parameters (used for guestinfo)

Will add documentation highlighting this.

@bcdurden bcdurden added the documentation Improvements or additions to documentation label Apr 3, 2024
@zackbradys zackbradys self-assigned this Apr 16, 2024
@zlmitchell
Copy link

@bcdurden @zackbradys
Yes the API is an array, the helmchart only allows a single value. The helmchart needs to be updated to allow an array in the values.yaml and be received in the following file

https://github.com/rancherfederal/rancher-cluster-templates/blob/main/charts/cluster-templates/templates/nodeconfig-vsphere.yaml#L18

@zackbradys
Copy link
Member

VMWare vSphere is still pending validation with rancher-cluster-templates. Please be patient as we try to test, validate, and support additional cloud providers.

https://github.com/rancherfederal/rancher-cluster-templates/tree/main/charts/cluster-templates#supported-providers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants