Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Add Multus DHCP DaemonSet creation logic #25

Open
Woovie opened this issue Jun 26, 2024 · 0 comments
Open

[RFE] Add Multus DHCP DaemonSet creation logic #25

Woovie opened this issue Jun 26, 2024 · 0 comments

Comments

@Woovie
Copy link

Woovie commented Jun 26, 2024

Problem

Presently if you want to enable Multus' DHCP DaemonSet features using our cluster templates, it will not correctly include them. This goes really for almost anything that would end up under the chartValues section of a Cluster template.

Proposed Solution

Similar to other sections of the configuration, it would be worthwhile to iteratively process the chartValues section and include those, although I can see that logic being very tricky with particularly cloudprovider options.

Example workaround code

I wrote a very basic solution to test a slight restructure of this section: Woovie@9ba217c

I do think that moving the chartValues key outside of the if blocks here would be a good change, but a lot of work needs to be done to do this right.

@Woovie Woovie changed the title Add Multus DHCP DaemonSet creation logic [RFE] Add Multus DHCP DaemonSet creation logic Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant