-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No native build was found - Node v20.11.0 and node-gyp-build 4.8.0, 4.8.1 #413
Comments
U: |
U: node-gyp-build: 4.8.0 doesn't work either, so the issue is somewhere in this 2 line change? |
tl;dr issue was with We had two separate node-gyp-build versions requested (as dependency of dependecy): ❯ yarn why node-gyp-build
├─ @parcel/watcher@npm:2.0.4
│ └─ node-gyp-build@npm:4.5.0 (via npm:^4.3.0)
│
├─ argon2@npm:0.40.3
│ └─ node-gyp-build@npm:4.8.1 (via npm:^4.8.0)
│
└─ leveldown@npm:6.1.1
└─ node-gyp-build@npm:4.5.0 (via npm:^4.3.0) This resolved to 2 different versions in yarn.lock:
But only one was installed:
The fix
Now only one version is correctly resolved and installed:
And we correctly use a prebuilt binary. |
@gligorot if you're using yarn 3 or 4, for some reason they don't dedupe anymore when installing, and it leads to a shitload of duplicate dependencies. In my company we added |
@ranisalt Good point, I'll integrate this on our side as well. Thanks for the input! |
Hi,
We have an issue with using
argon2
with version of Node afterv20.2.0
.Also reproduced on
v20.3.0
,v20.11.0
(our default) and also the latestv20.16.0
.Problem
node_modules/argon2/build
is missing - ie. argon2 didn't install properly but no errors are shownActual error (from our full project)
Update (26.08.2024)
Fixating node-gyp-build to 4.7.1 fixes this issue. I'll open an issue over there.
Minimal reproduction steps
note - same behavior with yarn
mkdir argon-test cd argon-test npm init
Expected behaviour
node_modules/argon2/build
is always present, regardless of the specific Node 20 versionOther details
The resolved version of argon2 in both cases is:
Actual behaviour
Tell us what happens instead
Environment
Operating system:
Sonoma 14.6.1 (23G93).
Apple Silicon (M1 Pro).
Node version:
Package manager version:
-- package.json -> "packageManager": "[email protected]",
Other relevant versions:
Python: 3.12, installed via pyenv (assuming it matters for node-gyp)
The text was updated successfully, but these errors were encountered: