Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference links crossing lines in blockquotes don't work. #393

Closed
ehuss opened this issue Aug 31, 2019 · 2 comments
Closed

Reference links crossing lines in blockquotes don't work. #393

ehuss opened this issue Aug 31, 2019 · 2 comments

Comments

@ehuss
Copy link
Contributor

ehuss commented Aug 31, 2019

The following links don't work within blockquotes, though I would expect them to work since they work outside of blockquotes (and they work in other implementations like dingus and github). The spec seems to imply that the leading > should be deleted and the paragraphs treated like they normally would.

> [foo
> bar]

[foo bar]: http://example.com

> [foo][bar
> baz]

[bar baz]: http://example.com

Inline links seem to work OK:

> [foo
> bar](http://example.com)

Tested latest master (3c9cdda).

cc #301 which is kinda similar.

@marcusklaas
Copy link
Collaborator

I can't test this myself right now, but I believe this PR should take care of this: #386

@ehuss
Copy link
Contributor Author

ehuss commented Aug 31, 2019

Oh, indeed it does! Sorry, I thought I searched through all the issues, but that one didn't come up. Seeing as this is almost identical, and fixed by #386, I'll close this. Thanks so much!

@ehuss ehuss closed this as completed Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants