You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are inconsistencies with the return value of the #getsockname method of Rex::Socket instances. This creates a problem when users of the socket call that method because they then need to know whether it's a Rex::Socket or a native Ruby socket. The return value of the Rex version should be the same as the native Ruby counterpart. Additionally, Rex also provides a #getlocalname method which is not provided by Ruby. The return value of this is also an array, which it seems like it should probably be a string like the other get name methods. This would be a breaking API change though.
The following table shows the return types of the various methods.
Rex::Socket
Native Ruby
#getsockname
array
string
#getpeername
string
string
#getlocalname
array
N/A
The text was updated successfully, but these errors were encountered:
Heh, we used to have handlers for jruby cases iirc.
This is "fixable" but the consumer audit would be BRUTAL, and we need to fix the logger thing first or this will be like blind clowns running a marathon in full-dress through a minefield.
There are inconsistencies with the return value of the
#getsockname
method ofRex::Socket
instances. This creates a problem when users of the socket call that method because they then need to know whether it's aRex::Socket
or a native Ruby socket. The return value of the Rex version should be the same as the native Ruby counterpart. Additionally, Rex also provides a#getlocalname
method which is not provided by Ruby. The return value of this is also an array, which it seems like it should probably be a string like the other get name methods. This would be a breaking API change though.The following table shows the return types of the various methods.
#getsockname
#getpeername
#getlocalname
The text was updated successfully, but these errors were encountered: