Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Use the official NVTX C++ API once available. #168

Open
gigony opened this issue Nov 30, 2021 · 1 comment
Open

[Improve] Use the official NVTX C++ API once available. #168

gigony opened this issue Nov 30, 2021 · 1 comment
Assignees
Labels
feature request New feature or request improvement Improves an existing functionality

Comments

@gigony
Copy link
Contributor

gigony commented Nov 30, 2021

Is your feature request related to a problem? Please describe.

Since C++ helper classes in NVTX exists on dev branch only and they are not merged into main branch, cuCIM is using a latest dev branch commit (https://github.com/NVIDIA/NVTX/tree//3c98c8425b0376fd8653aac7cfc6a864f3897752/cpp) to use the helper classes.

To import a specific commit (instead of branch/tag), the full git repository is cloned.

if (NOT TARGET deps::nvtx3)
    FetchContent_Declare(
            deps-nvtx3
            GIT_REPOSITORY https://github.com/NVIDIA/NVTX.git
            GIT_TAG 3c98c8425b0376fd8653aac7cfc6a864f3897752
            # GIT_SHALLOW TRUE  # Uncomment this when the official release of nvtx3-cpp is available.
            ...

We need to uncomment the line once nvtx3-cpp is available.

Describe the solution you'd like

Uncomment the line ( # GIT_SHALLOW TRUE ) and use a specific tag once nvtx3-cpp is available.

Additional context

Should we raise an issue to track this?

Originally posted by @jakirkham in #144 (comment)

@gigony gigony added feature request New feature or request improvement Improves an existing functionality labels Nov 30, 2021
@gigony gigony self-assigned this Nov 30, 2021
@caryr35 caryr35 added this to cucim Nov 15, 2022
@jakirkham jakirkham added this to the v24.06 milestone Apr 16, 2024
@jakirkham
Copy link
Member

Think this might be doable now. Though we should double check

@jakirkham jakirkham moved this to Todo in cucim Apr 16, 2024
@jakirkham jakirkham modified the milestones: v24.06.00, v24.08.00 Jun 25, 2024
@jakirkham jakirkham removed this from the v24.08.00 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request improvement Improves an existing functionality
Projects
Status: Todo
Development

No branches or pull requests

2 participants