Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support strong index types in other cudf::experimental::row:: comparators and hashers #11091

Open
ttnghia opened this issue Jun 10, 2022 · 5 comments
Labels
0 - Backlog In queue waiting for assignment feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@ttnghia
Copy link
Contributor

ttnghia commented Jun 10, 2022

When we have multiple tables to compare, we need strong index types. On the other hand, when we just do one table operations like comparing or hashing rows of the same table, we typically don't need these strong types.

However, sometimes we actually need to support strong types in these self- operations. For example, we create a hash map with strong index types. In such cases, row comparator and hasher need to operate on strong index types.

@ttnghia ttnghia added feature request New feature or request Needs Triage Need team to review and classify labels Jun 10, 2022
@ttnghia
Copy link
Contributor Author

ttnghia commented Jun 10, 2022

CC @bdice for awareness.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

github-actions bot commented Oct 8, 2022

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@GregoryKimball GregoryKimball added 0 - Backlog In queue waiting for assignment libcudf Affects libcudf (C++/CUDA) code. and removed inactive-30d Needs Triage Need team to review and classify labels Oct 21, 2022
@GregoryKimball
Copy link
Contributor

GregoryKimball commented Oct 21, 2022

sometimes we actually need to support strong types in these self- operations

@ttnghia would you please elaborate on this use case? What code changes would you propose?

This issue references competed work in #10730

@ttnghia
Copy link
Contributor Author

ttnghia commented Oct 26, 2022

The use cases already existed, and implementation of this FEA was added here:

I proposed this issue and already made a draft PR but that was not approved so I had to implement it locally only in that file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog In queue waiting for assignment feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

No branches or pull requests

2 participants