Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rapids-build-backend for cugraph-gnn and cugraph-pyg #15

Closed
jameslamb opened this issue Jul 24, 2024 · 0 comments · Fixed by #59
Closed

use rapids-build-backend for cugraph-gnn and cugraph-pyg #15

jameslamb opened this issue Jul 24, 2024 · 0 comments · Fixed by #59
Assignees

Comments

@jameslamb
Copy link
Member

jameslamb commented Jul 24, 2024

Description

The cugraph-gnn and cugraph-pyg packgaes currently use setuptools as their build backends.

build-backend = "setuptools.build_meta"

[build-system]
requires = [
"setuptools>=61.0.0",
"wheel",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.

They should use `rapids-build-backend.

Benefits of this work

Would make these projects' build systems consistent with the rest of RAPIDS.

Would reduce the need for complexity like this in build scripts:

sed -i "s/name = \"${package_name}\"/name = \"${package_name}${PACKAGE_CUDA_SUFFIX}\"/g" ${pyproject_file}
echo "${version}" > VERSION
sed -i "/^__git_commit__ / s/= .*/= \"${git_commit}\"/g" ${version_file}
# For nightlies we want to ensure that we're pulling in alphas as well. The
# easiest way to do so is to augment the spec with a constraint containing a
# min alpha version that doesn't affect the version bounds but does allow usage
# of alpha versions for that dependency without --pre
alpha_spec=''
if ! rapids-is-release-build; then
alpha_spec=',>=0.0.0a0'
fi
for dep in rmm cudf cugraph raft-dask pylibcugraph pylibcugraphops pylibwholegraph pylibraft ucx-py; do
sed -r -i "s/${dep}==(.*)\"/${dep}${PACKAGE_CUDA_SUFFIX}==\1${alpha_spec}\"/g" ${pyproject_file}
done

Acceptance Criteria

Approach

Follow the work in these examples:

And other things described in rapidsai/build-planning#31.

Notes

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant