Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QST] Best practices for using with_cupy_rmm vs rmm_cupy_ary #2485

Closed
beckernick opened this issue Jun 26, 2020 · 3 comments
Closed

[QST] Best practices for using with_cupy_rmm vs rmm_cupy_ary #2485

beckernick opened this issue Jun 26, 2020 · 3 comments
Labels
question Further information is requested

Comments

@beckernick
Copy link
Member

It's often desirable to use RMM as the memory allocator for CuPy functions. At the function execution level, this can be done by wrapping the function call with rmm_cupy_ary. At the function definition level, this can be done by using the with_cupy_rmm decorator.

Both of these approaches are used across the codebase. For developers looking to contribute, are there guidelines as to when they should opt for execution level RMM allocation vs definition level allocation? Should all cuML function definitions calling CuPy functions be decorated with with_cupy_rmm?

@beckernick beckernick added the question Further information is requested label Jun 26, 2020
@github-actions
Copy link

This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@github-actions
Copy link

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

@beckernick
Copy link
Member Author

As noted in #3409 (comment) , we can now close this issue. Both of these can be deprecated in favor of @cuml.internals.api_return_any(). More detailed information can be found in the Estimator Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant