-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Enable test parallelism #5027
Comments
@vyasr Maybe you can provide a little bit more context? |
Yup, the current issue that I run into is that the different workers collect different tests. Offhand I would guess that the problem is one of the following:
I've attached the output that I see. |
The non-determinism in test collection should be fixed by #5059, but it looks like we've got issues with some of the tests themselves unrelated to the question of parallelism. |
Could you clarify what issues you're talking about? Are these issues that prevent the usage of parallelism (perhaps because of GPU overutilization or memory requirements), unrelated issues that lead to long test times (aka #5053), or something else? |
Sorry, I was actually referring to unrelated failures that were present across PRs. That has been resolved, but now there are indeed failures which look like they're definitely caused by the parallelism itself. Specifically, we're seeing:
|
xdist is now being used in the GHA based CI |
As reported by @vyasr there are currently some issues with running tests in paralle using
pytest-xdist
. We should resolve those to significantly reduce cuml's test runtime when multiple workers are available.The text was updated successfully, but these errors were encountered: