Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add DiskANN Search support #394

Open
bkarsin opened this issue Oct 3, 2024 · 2 comments
Open

[FEA] Add DiskANN Search support #394

bkarsin opened this issue Oct 3, 2024 · 2 comments
Assignees
Labels
feature request New feature or request improvement Improves an existing functionality

Comments

@bkarsin
Copy link
Contributor

bkarsin commented Oct 3, 2024

Add DiskANN search functionality for the current Vamana build. Already have a GreedySearch kernel as part of build, but need to edit, optimize, and possibly add more options.

If possible, would be good to bring in ideas / improvements from the BANG paper work: https://arxiv.org/abs/2401.11324.

@bkarsin bkarsin added feature request New feature or request improvement Improves an existing functionality labels Oct 3, 2024
@cjnolet
Copy link
Member

cjnolet commented Oct 28, 2024

@bkarsin the current plan here is to bring in BANG for this, and we have discussed with the authors of BANG that the shortest path to initial capability is to add the BANG repository as a (build-time) dependency and invoking it directly to start, while we work to improve the BANG code itself (eg. using RMM, etc...) to contribute back upstream. The BANG authors would like to keep this separation, but in the meantime we can make our changes to the BANG code in the form of a git branch and patch it directly in cuVS while we wait to upstream it.

cc @tarang-jain

@bkarsin
Copy link
Contributor Author

bkarsin commented Oct 28, 2024

Ok, that sounds good. Would it eventually be incorporated directly into the cuvs codebase or always be a build-time dependency on a branch of their repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request improvement Improves an existing functionality
Projects
Development

No branches or pull requests

3 participants