Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Current Page on "Per Page" changing #1953

Merged

Conversation

lrljoe
Copy link
Sponsor Collaborator

@lrljoe lrljoe commented Sep 18, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe merged commit 07e8dbc into rappasoft:development Sep 18, 2024
7 checks passed
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.27%. Comparing base (0c8ec45) to head (20691dd).
Report is 97 commits behind head on development.

Files with missing lines Patch % Lines
src/Traits/WithPagination.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #1953      +/-   ##
=================================================
+ Coverage          87.30%   88.27%   +0.97%     
- Complexity          1672     1839     +167     
=================================================
  Files                150      172      +22     
  Lines               3891     4240     +349     
=================================================
+ Hits                3397     3743     +346     
- Misses               494      497       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Changing 'Per Page' Dropdown on Non-First Page Shows 0 Results
1 participant