Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setleds doesnt work with scrolllock #1516

Closed
n0rt0nthec4t opened this issue Jun 5, 2016 · 17 comments
Closed

setleds doesnt work with scrolllock #1516

n0rt0nthec4t opened this issue Jun 5, 2016 · 17 comments

Comments

@n0rt0nthec4t
Copy link

The latest raspbain release using setleds -L +scroll no longer sets the scroll lock led on. Using +caps or +num still works

This was working on a build of RetroPie 3.6/3.7 but the latest 3.8.1 no longer works. I tried a clean installed on Jessie (2016/5/27) and the problem still persists

@n0rt0nthec4t n0rt0nthec4t changed the title settled doesnt work with scrolllock setleds doesnt work with scrolllock Jun 5, 2016
@popcornmix
Copy link
Collaborator

Are you getting an error message, or does it appear to work but not affect the LEDs?

@n0rt0nthec4t
Copy link
Author

No error message and setleds says the led should be on but it does not light. Some more testing I have been doing using ioctl directly to set keyboard LEDs and again, nun and caps work but not scroll

@popcornmix
Copy link
Collaborator

What is the kernel version on working and non-working systems? (uname -a)

@n0rt0nthec4t
Copy link
Author

non-working is
Linux AmigaPI 4.4.11-v7+ #888 SMP Mon May 23 20:10:33 BST 2016 armv7l GNU/Linux

I'll post the work tonight, but from memory the kernel was 4.1.x

@popcornmix
Copy link
Collaborator

Can you identify the exact update which caused this. See:
https://github.com/Hexxeh/rpi-firmware/commits/master

If you click on each commit the end of the url contains a git hash. Run
sudo rpi-update <hash>
to revert back to that version. Report the first version with this error.

@n0rt0nthec4t
Copy link
Author

The kernel commit on 12/4/2016 to update to 4.4.6 breaks this. Prior to this, all works fine

date commit hash name -a Status
7 April 2016 dea25fa62132365c11087e51e416df656db28bf3 Linux retropie 4.1.21-v7+ #872 SMP Wed Apr 6 17:34:14 BST 2016 armv7l GNU/Linux OK
9 April 2016 4bc6b67905e3206f8cf4d9a316f3343aaaf14d62 Linux retropie 4.1.21-v7+ #872 SMP Wed Apr 6 17:34:14 BST 2016 armv7l GNU/Linux OK
11 April 2016 826a75550fc731f2a2dacf5d776d09d008ec37b5 Linux retropie 4.1.21-v7+ #872 SMP Wed Apr 6 17:34:14 BST 2016 armv7l GNU/Linux OK
12 April 2016 771a503cfc2a1130e2df2a4ddfc45ffa0f592b3f Linux retropie 4.1.21-v7+ #873 SMP Mon Apr 11 18:22:10 BST 2016 armv7l GNU/Linux OK
12 April 2016 c05b9e6fba9cc2ce9e47abf41b8d413b2a69d952 Linux retropie 4.4.6-v7+ #874 SMP Mon Apr 11 19:20:24 BST 2016 armv7l GNU/Linux Failed

@popcornmix
Copy link
Collaborator

Okay, this will be an upstream change that likely affects all linux platforms running 4.4.x kernels.
What is the make/model of keyboard?

@n0rt0nthec4t
Copy link
Author

Generic Dell 101 keyboard
Microsoft Natural Keyboard
Keyrah v2 connected to Amiga 600 keyboard

@n0rt0nthec4t
Copy link
Author

n0rt0nthec4t commented Jun 13, 2016

an updated.. creating a udev rule with the following enables the scrollock led to function as per normal. Doest appear a default trigger gets set for the scrollock key for the led class.

ACTION=="add", SUBSYSTEM=="leds", ENV{DEVPATH}=="/input::scrolllock", ATTR{trigger}="kbd-scrollock"

@n0rt0nthec4t
Copy link
Author

n0rt0nthec4t commented Aug 29, 2016

Appears I have a typo in my rules above

create a file in /etc/udev/rules.d

mine was called 50-leds.rules

It contains the following

ACTION=="add", SUBSYSTEM=="leds", ENV{DEVPATH}=="*/input/*::scrolllock", ATTR{trigger}="kbd-scrollock"

@pelwell
Copy link
Contributor

pelwell commented Aug 29, 2016

Try with three "l"s in "kbd-scrolllock".

@n0rt0nthec4t
Copy link
Author

n0rt0nthec4t commented Aug 29, 2016

no, only 2 l's in kbd-scrollock
weird I know

and some wildcards that seem to have gotten remove in my initial report.. fixed above

@prefim
Copy link

prefim commented Aug 29, 2016

I wonder if the same fix can be applied for caps lock?

@pelwell
Copy link
Contributor

pelwell commented Aug 29, 2016

But the source (http://lxr.free-electrons.com/source/drivers/input/input-leds.c?v=4.4#L30) says:

[LED_SCROLLL]   = { "scrolllock", VT_TRIGGER("kbd-scrolllock") },

@JamesH65
Copy link
Contributor

Closing due to lack of activity. Reopen if you feel this issue is still relevant.

@markusobi
Copy link

markusobi commented May 14, 2019

This issue is still relevant. It is still broken on latest raspbian:
Tested on on Raspberry Pi 3B+
OS:
Raspbian Stretch with desktop
Image with desktop based on Debian Stretch
Version: April 2019
Release date: 2019-04-08
Kernel version: 4.14

Scroll lock LED still doesn't work.

@JamesH65
Copy link
Contributor

JamesH65 commented May 14, 2019

Just tried setleds -L +scroll and a number of other combinations on a pi3B+ with 4.19.42 and it seemed to work as expected. Did from command line, not running desktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants