Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usb assertion "hw_data_offset(next_buffer_ptr) <= USB_DPRAM_MAX" #85

Closed
ndinsmore opened this issue Feb 4, 2021 · 11 comments · Fixed by #462
Closed

Usb assertion "hw_data_offset(next_buffer_ptr) <= USB_DPRAM_MAX" #85

ndinsmore opened this issue Feb 4, 2021 · 11 comments · Fixed by #462
Assignees
Milestone

Comments

@ndinsmore
Copy link

This is a duplicate of the issue I created at please see the issue there for sull documentation:
hathach/tinyusb/issues/628

In the issue I created in the tinyusb repo I mention that I am using the new code coming directly from that repo, but the code at that is at issue is in the SDK tiny USB repo as well.

@lurch
Copy link
Contributor

lurch commented Feb 5, 2021

Sounds like something @liamfraser needs to look at?

@ndinsmore
Copy link
Author

This issue is fixed by hathach/tinyusb#642 @liamfraser it is one real line of code so it should be easy for you to take a look at.

@liamfraser
Copy link
Contributor

Looks like a plausible fix to me. I think the audio example may be the first one that repeatedly opens and closes an ep which is why we didn't see this?

@liamfraser
Copy link
Contributor

(I don't own the upstream tinyusb repo so I can't merge the PR)

@hathach
Copy link
Contributor

hathach commented Feb 10, 2021

@liamfraser please accept my contributor invitation, and feel free to review, approval and merge any PRs that make sense to you. I still haven't got into the usb specs of rp2040 yet. Worse I am on vacation just now 😉

@liamfraser
Copy link
Contributor

@ndinsmore I have merged this into tinyusb upstream

@liamfraser
Copy link
Contributor

Will keep this open until either a) our sdk tracks upstream or b) we pick this commit into our fork. We need to review what changes have been made in tinyusb upstream before switching the SDK to it.

@kilograham
Copy link
Contributor

closing in favor of #161

@kilograham kilograham reopened this Apr 8, 2021
@kilograham kilograham self-assigned this Apr 8, 2021
@kilograham
Copy link
Contributor

changed my mind, will get closed with #321

@kilograham
Copy link
Contributor

actually closed by #462

@kilograham kilograham added this to the 1.2.0 milestone May 31, 2021
@kilograham kilograham linked a pull request May 31, 2021 that will close this issue
@kilograham
Copy link
Contributor

released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants