Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This will crash if options.nopreview is true #22

Closed
jhihn opened this issue Mar 26, 2021 · 4 comments
Closed

This will crash if options.nopreview is true #22

jhihn opened this issue Mar 26, 2021 · 4 comments

Comments

@jhihn
Copy link

jhihn commented Mar 26, 2021

https://github.com/raspberrypi/libcamera-apps/blob/4bb40bb0841b62df953577a41865b70e4732b199/libcamera_app.hpp#L149

@jhihn
Copy link
Author

jhihn commented Mar 26, 2021

In fact, there are a few scenarios in the preceding if block which will set preview_ to null, which will crash at this line.

@davidplowman
Copy link
Collaborator

Hi, thanks for reporting the issue. Unfortunately I haven't quite understood exactly what the problem is - what have you typed at the command line that causes the libcamera-apps to crash? Thanks!

@davidplowman
Copy link
Collaborator

If there's no further information I'm going to propose closing this issue in the next few days. I haven't spotted how the preview_ variable could be null, and the apps seem to work OK when options.nopreview is true. But if there's anything I've overlooked, please post an update. Thanks.

@jhihn
Copy link
Author

jhihn commented Apr 9, 2021

I guess I was wrong. Huh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants