From 0b4c69a158f6dc8363fdfbdbb663c3d53d2f09ed Mon Sep 17 00:00:00 2001
From: Jonathan Little <rationull@gmail.com>
Date: Fri, 17 Aug 2018 15:20:37 -0700
Subject: [PATCH] Protect ScriptedMetricIT test cases against failures on 0-doc
 shards (#32959)

Randomized test conditions that cause some shards to have no docs on them
failed due to test asserts that relied on a lazy initialization side effect
from the map script. After this fix:

- Test cases with the relevant init script are protected
- Test cases with the relevant combine or reduce scripts were already
  protected, because the combine and reduce scripts safely handle this case.
---
 .../search/aggregations/metrics/ScriptedMetricIT.java  | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/server/src/test/java/org/elasticsearch/search/aggregations/metrics/ScriptedMetricIT.java b/server/src/test/java/org/elasticsearch/search/aggregations/metrics/ScriptedMetricIT.java
index c000b7fb22891..f62598fa7c317 100644
--- a/server/src/test/java/org/elasticsearch/search/aggregations/metrics/ScriptedMetricIT.java
+++ b/server/src/test/java/org/elasticsearch/search/aggregations/metrics/ScriptedMetricIT.java
@@ -108,8 +108,14 @@ protected Map<String, Function<Map<String, Object>, Object>> pluginScripts() {
                     aggScript(vars, state -> state.put((String) XContentMapValues.extractValue("params.param1", vars),
                         XContentMapValues.extractValue("params.param2", vars))));
 
-            scripts.put("vars.multiplier = 3", vars ->
-                    ((Map<String, Object>) vars.get("vars")).put("multiplier", 3));
+            scripts.put("vars.multiplier = 3", vars -> {
+                ((Map<String, Object>) vars.get("vars")).put("multiplier", 3);
+
+                Map<String, Object> state = (Map<String, Object>) vars.get("state");
+                state.put("list", new ArrayList());
+
+                return state;
+            });
 
             scripts.put("state.list.add(vars.multiplier)", vars ->
                     aggScript(vars, state -> {