Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export mlir_sys #588

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Re-export mlir_sys #588

wants to merge 1 commit into from

Conversation

cospectrum
Copy link

To close #583

@raviqqe
Copy link
Owner

raviqqe commented Sep 24, 2024

@edg-l Do you think this is a good change?

I feel like this is the responsibility of the package manager (i.e. Cargo.) But at the same time, I've never hit problems @cospectrum described in the original issue.

@edg-l
Copy link
Contributor

edg-l commented Sep 24, 2024

I dont have an opinion on this, but with cargo you can have multiple versions with package renaming

@raviqqe
Copy link
Owner

raviqqe commented Sep 24, 2024

@edg-l Yeah, that's what I've suggested in #583 too.

@cospectrum How critical is this change to your workflow?

@cospectrum
Copy link
Author

Well, that's quite important for me. Every time I run cargo update, for example, the workspace has a chance to not compile anymore, and cargo will not prevent it. To fix the compile error, I should find melior version in Cargo.lock, then find out exact version of its mlir_sys somewhere (crates.io or lock file), and then I should downgrade my own mlir_sys in Cargo.toml manually.

@cospectrum
Copy link
Author

I think PR will not cause problems at all. But it will solve one problem for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-export mlir_sys
3 participants