Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Whether to remove init_image parameter in Python client module #1072

Closed
1 of 2 tasks
jasoonn opened this issue May 9, 2023 · 1 comment
Closed
1 of 2 tasks
Labels
enhancement New feature or request

Comments

@jasoonn
Copy link
Contributor

jasoonn commented May 9, 2023

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

The parameter init_image in the function build_worker() is originally used to set the image in init container in worker group spec. However, after #973, the init container is no longer needed for worker group spec, and the code snippet relevant to init container in Python-client are removed in #1006. Hence, the init_image became a redundant parameter.

On the other hand, because build_worker() is a user-facing, removing init_image will break backward compatibility.
Hence, I am wondering whether it is a good idea to remove init_image from build_worker().

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421
Copy link
Member

We learned several lessons in these two months, which underscore the importance of keeping the init image configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants