Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Publish images to alternative registry #1133

Closed
2 tasks done
anishasthana opened this issue Jun 1, 2023 · 8 comments
Closed
2 tasks done

[Feature] Publish images to alternative registry #1133

anishasthana opened this issue Jun 1, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@anishasthana
Copy link
Contributor

anishasthana commented Jun 1, 2023

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

DockerHub allows you to pull only 100 images per 6 hour window[1], which isn't a lot. This results in the following error occurring fairly frequently.

Failed to pull image "kuberay/operator:v0.3.0": rpc error: code = Unknown desc = initializing source docker://kuberay/operator:v0.3.0: reading manifest v0.3.0 in docker.io/kuberay/operator: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

There are other container registries such as quay.io we could push images to instead (or as well) so as to get around the rate limit issues.

[1] https://docs.docker.com/docker-hub/download-rate-limit/

Use case

Reduce instances of rate limit errors when pulling images from DockerHub.

Related issues

#829
opendatahub-io/distributed-workloads#47

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@nvtkaszpir
Copy link

you can always make your own registry and pull/push images there.

@anishasthana
Copy link
Contributor Author

Yep, that's what we're currently doing -- we just copied images over into our own registry. That being said, it's just another point of friction for new users, so in an ideal world we lower the bar to entry for anyone.

@kevin85421
Copy link
Member

@anishasthana Do you have any recommendation for this issue? Thanks!

@anishasthana
Copy link
Contributor Author

My recommendation would be:

  1. Create a KubeRay organization on quay.io
  2. Create a robot account which we can use for image pushes
  3. Update https://github.com/ray-project/kuberay/blob/master/.github/workflows/image-release.yaml#L66-L70 and https://github.com/ray-project/kuberay/blob/master/.github/workflows/image-release.yaml#L124-L128 to push the images to quay. We would need to add corresponding log-in steps too

I'm happy to assist on any of this -- I'm quite familiar with quay.
We are actually primarily using quay.io for Project CodeFlare (the organization under which MCAD resides).

@Jeffwan
Copy link
Collaborator

Jeffwan commented Jun 6, 2023

@kevin85421 Can anyscale offer some premium plans for dockerhub kuberay? or just host kuberay under dockerhub ray-project?

@anishasthana
Copy link
Contributor Author

The issue would be on the pulling side -- anyone wanting to pull images would also need a premium plan with dockerhub to not be rate-limited.

@kevin85421
Copy link
Member

Thank you, @anishasthana, for the insightful suggestion! We will discuss this internally to determine if there is an existing solution in Ray or not, and we will get back to you as soon as possible.

@kevin85421
Copy link
Member

This issue can be closed by #1307. Thank @anishasthana for the guidance! The next step is to update the doc and may be change the default image registry to Quay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants