Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RayJob] Add tests for #1855 #1866

Closed
2 tasks done
kevin85421 opened this issue Jan 24, 2024 · 1 comment · Fixed by #1871
Closed
2 tasks done

[RayJob] Add tests for #1855 #1866

kevin85421 opened this issue Jan 24, 2024 · 1 comment · Fixed by #1871
Assignees
@kevin85421
Labels
enhancement New feature or request rayjob

Comments

@kevin85421
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

#1855

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added the enhancement New feature or request label Jan 24, 2024
@kevin85421 kevin85421 self-assigned this Jan 24, 2024
@kevin85421 kevin85421 mentioned this issue Jan 24, 2024
Merged
4 tasks
@architkulkarni
Copy link
Contributor

It may involve significant changes because it needs to execute a command in the head Pod, a process not currently used in the existing RayJob e2e tests.

If we're talking about the ray job stop, we might be able to just do it using JobSubmissionClient.stop_job inside the Ray job entrypoint itself.

@kevin85421 kevin85421 mentioned this issue Jan 26, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin85421 kevin85421

Labels
enhancement New feature or request rayjob
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Test][RayJob] Transition to Complete if the JobStatus is STOPPED kevin85421/kuberay
2 participants
@architkulkarni @kevin85421