Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support namespace scoped deployment #227

Closed
1 of 2 tasks
Jeffwan opened this issue Apr 11, 2022 · 3 comments
Closed
1 of 2 tasks

[Feature] Support namespace scoped deployment #227

Jeffwan opened this issue Apr 11, 2022 · 3 comments
Labels
deployment enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Apr 11, 2022

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

In our company, we start to limit the access to platform users on Kubernetes cluster. That means, user will only have permission to operate objects in single namespace. cluster level objects like crds, clusterroles, clusterrolerolebings has to be submited to ops team and ask them to apply to the cluster.

In this case, current deployment way doesn't work in one-click.

kubectl apply -k "github.com/ray-project/kuberay/manifests/cluster-scope-resources"
kubectl apply -k "github.com/ray-project/kuberay/manifests/base"

We need to provide a kustomize override to limit the kuberay to single specificed namespace for a successful deployment.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@Jeffwan Jeffwan added the enhancement New feature or request label Apr 11, 2022
@wilsonwang371
Copy link
Collaborator

What is our new expectation on this change?

  1. Shall we separate crds, clusterroles, clusterrolerolebings yamls to different places?
  2. are we supposed to change this apply procedure to a two phases? 1. apply controllers. 2 apply required crds, clusterroles, clusterrolerolebings yamls

@DmitriGekhtman
Copy link
Collaborator

@wilsonwang371 @Jeffwan we covered this in #258 right?

@kevin85421
Copy link
Member

Close this issue because it is covered by #258 and #860. Feel free to reopen this issue if I am wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants