Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Remove block: true in configuration YAML files after release 0.5.0 #971

Closed
1 of 2 tasks
Tracked by #940
Yicheng-Lu-llll opened this issue Mar 16, 2023 · 2 comments
Closed
1 of 2 tasks
Tracked by #940

[Feature] Remove block: true in configuration YAML files after release 0.5.0 #971

Yicheng-Lu-llll opened this issue Mar 16, 2023 · 2 comments
Assignees
@Yicheng-Lu-llll
Labels
enhancement New feature or request

Comments

@Yicheng-Lu-llll
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

We plan to inject the --block option to ray start command automatically(see #932). As a result, it will no longer be necessary to include block: true in the rayStartParams in the configuration YAML files.

However, To maintain compatibility with both the nightly and the latest release of the KubeRay operator, we should remove block: true from the configuration YAML files after the release of version 0.5.0.

Use case

No response

Related issues

#932

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@Yicheng-Lu-llll Yicheng-Lu-llll added the enhancement New feature or request label Mar 16, 2023
@kevin85421 kevin85421 mentioned this issue Mar 16, 2023
Closed
5 tasks
@kevin85421
Copy link
Member

Finish some parts of this issue in #1015 to continue with the process. The others can be resolved by other PRs later.

@Yicheng-Lu-llll Yicheng-Lu-llll mentioned this issue Apr 25, 2023
Closed
@kevin85421
Copy link
Member

Close by #1050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yicheng-Lu-llll Yicheng-Lu-llll

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@kevin85421 @Yicheng-Lu-llll