-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nit] Make sure Ray Serve installs ray[default] #19262
Labels
enhancement
Request for new feature and/or capability
good first issue
Great starter issue for someone just starting to contribute to Ray
P1
Issue that should be fixed within a few weeks
serve
Ray Serve Related Issue
Comments
triciasfu
added
enhancement
Request for new feature and/or capability
serve
Ray Serve Related Issue
labels
Oct 9, 2021
simon-mo
added
the
good first issue
Great starter issue for someone just starting to contribute to Ray
label
Oct 11, 2021
For this, let's add a test that:
@simon-mo @architkulkarni could we re-use the runtime_env testing mechanism for installing the wheel built in CI for (2)? |
I tried running this: import ray
from ray import serve
serve.start()
@serve.deployment(ray_actor_options={"runtime_env": {"pip": ["requests"]}})
class A:
pass
A.deploy() and it hangs without any warning:
|
hint: just duplicate the ray minimal install tests and add some smart things to runtime env (serve inject ray serve into runtime env) |
triciasfu
changed the title
Make sure Ray Serve installs ray[default]
[nit] Make sure Ray Serve installs ray[default]
Oct 18, 2021
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Request for new feature and/or capability
good first issue
Great starter issue for someone just starting to contribute to Ray
P1
Issue that should be fixed within a few weeks
serve
Ray Serve Related Issue
No description provided.
The text was updated successfully, but these errors were encountered: