Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Train] Network interface discovery broken for HorovodBackend #19516

Closed
2 tasks done
tgaddair opened this issue Oct 19, 2021 · 0 comments · Fixed by #19533
Closed
2 tasks done

[Bug][Train] Network interface discovery broken for HorovodBackend #19516

tgaddair opened this issue Oct 19, 2021 · 0 comments · Fixed by #19533
Assignees
Labels
bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@tgaddair
Copy link
Contributor

Search before asking

  • I searched the issues and found no similar issues.

Ray Component

Ray Train

What happened + What you expected to happen

If the user does not manually specify the NICs in the HorovodConfig when running in a multi-node cluster, Horovod will attempt to discover the compatible NICs automatically. However, this process is currently broken in Ray Train, as the HorovodConfig object does not conform to the expected Settings interface.

Versions / Dependencies

Ray 1.7.0

Reproduction script

Run any Ray Train script with Horovod and multiple nodes.

Anything else

I have a fix for this in Ludwig here:

ludwig-ai/ludwig@6cd6a87

I'll put together a fix in Ray Train based on these changes.

I also want to make some changes to the Horovod on Ray code in Horovod itself, as some aspects of these changes are pretty hacky. Ideally, we should try to move as much of this into Ray Train as possible, so there is not this circular dependency between Ray Train and Horovod. Ideally, there should be a strict separation between Horovod as the dependency for Ray Train, similar to how other backends are managed.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@tgaddair tgaddair added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Oct 19, 2021
@tgaddair tgaddair self-assigned this Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant