Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] cut/paste typo in python/ray/tune/schedulers/__init__.py on line 58 #19605

Closed
2 tasks done
amholler opened this issue Oct 21, 2021 · 0 comments · Fixed by #19642
Closed
2 tasks done

[Bug] cut/paste typo in python/ray/tune/schedulers/__init__.py on line 58 #19605

amholler opened this issue Oct 21, 2021 · 0 comments · Fixed by #19642
Labels
bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@amholler
Copy link

amholler commented Oct 21, 2021

Search before asking

  • I searched the issues and found no similar issues.

Ray Component

Ray Tune

What happened + What you expected to happen

When calling RayTune from Ludwig, I had incorrectly specified scheduler type as skopt and search_alg type
as fifo, so the error message from RayTune was really confusing (see below).

{   'executor': {   'cpu_resources_per_trial': 1,
                    'gpu_resources_per_trial': 1,
                    'type': 'ray'},
    'goal': 'minimize',
    'metric': 'loss',
    'output_feature': 'combined',
    'parameters': {   'training.batch_size': {   'categories': [512, 1024],
                                                 'space': 'choice'}},
    'sampler': {   'num_samples': 2,
                   'scheduler': {'max_t': 1, 'type': 'skopt'},
                   'search_alg': {'type': 'fifo'},
                   'type': 'ray'},
    'split': 'validation'}
ValueError: Search alg must be one of ['fifo', 'async_hyperband', 'asynchyperband', 'median_stopping_rule', 'medianstopping', 'hyperband', 'hb_bohb', 'pbt', 'pbt_replay', 'pb2', 'resource_changing']. Got: skopt

So eventually I figured out the error message from RayTune was incorrect & I needed to swap the type values for scheduler and search_alg. Filing this issue so others won't be confused.

Versions / Dependencies

Observed with current top of master commit 19e3280

Reproduction script

Swap the type parameters to RayTune as shown.

Anything else

Always happens on incorrect input

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@amholler amholler added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant