Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Train] Document Callbacks #21066

Open
matthewdeng opened this issue Dec 14, 2021 · 0 comments
Open

[Train] Document Callbacks #21066

matthewdeng opened this issue Dec 14, 2021 · 0 comments
Labels
docs An issue or change related to documentation enhancement Request for new feature and/or capability P3 Issue moderate in impact or severity ray-team-created Ray Team created train Ray Train Related Issue
Milestone

Comments

@matthewdeng
Copy link
Contributor

Best practices for adding Ray Train Callbacks should be documented. When adding a new Callback, it should be clear what existing components can be leveraged or extended.

Some patterns to think about:

  1. Class inheritance, metaclasses, mixins.
  2. Composability of common functionality.
  3. Adding arguments and using **info kwargs.
  4. Ray Tune Callback interoperability ([Train][Tune] Unify Train and Tune Callbacks #21065).

This may also involve refactoring the current Callbacks to follow a more extensible pattern.

@matthewdeng matthewdeng added enhancement Request for new feature and/or capability docs An issue or change related to documentation train Ray Train Related Issue labels Dec 14, 2021
@matthewdeng matthewdeng added this to the Train backlog milestone Dec 14, 2021
@amogkam amogkam added the P3 Issue moderate in impact or severity label Apr 11, 2022
@richardliaw richardliaw added the ray-team-created Ray Team created label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation enhancement Request for new feature and/or capability P3 Issue moderate in impact or severity ray-team-created Ray Team created train Ray Train Related Issue
Projects
None yet
Development

No branches or pull requests

3 participants