Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Serve shutdown does not work for detached serve instance #22254

Closed
2 tasks done
saswatac opened this issue Feb 9, 2022 · 2 comments · Fixed by #23476
Closed
2 tasks done

[Bug] Serve shutdown does not work for detached serve instance #22254

saswatac opened this issue Feb 9, 2022 · 2 comments · Fixed by #23476
Assignees
Labels
bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks

Comments

@saswatac
Copy link

saswatac commented Feb 9, 2022

Search before asking

  • I searched the issues and found no similar issues.

Ray Component

Ray Serve

What happened + What you expected to happen

Trying to shutdown a detached ray serve instance using serve.shutdown does not work.

Versions / Dependencies

ray==1.10.0

python=3.8.0

NAME="Ubuntu"
VERSION="18.04.6 LTS (Bionic Beaver)"

Reproduction script

import ray
ray.init(address="ray://example-cluster-ray-head.ray:10001", namespace="x")
from ray import serve
serve.shutdown()

Anything else

The problem is resolved if another serve API is called before shutdown

import ray
ray.init(address="ray://example-cluster-ray-head.ray:10001", namespace="x")
from ray import serve
serve.list_deployments()
serve.shutdown()

I think this if clause is unnecessary and it is what is causing the bug - https://github.com/ray-project/ray/blob/master/python/ray/serve/api.py#L703

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@saswatac saswatac added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Feb 9, 2022
@architkulkarni architkulkarni added P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Feb 10, 2022
@architkulkarni
Copy link
Contributor

Hi @shrekris-anyscale, can I assign this issue to you? Do you think you have enough context to investigate it?

@shrekris-anyscale
Copy link
Contributor

Hi @architkulkarni, yes go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants