Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune/CI] SigOpt Tests are skipped in CI #26567

Closed
Yard1 opened this issue Jul 14, 2022 · 2 comments · Fixed by #28225
Closed

[Tune/CI] SigOpt Tests are skipped in CI #26567

Yard1 opened this issue Jul 14, 2022 · 2 comments · Fixed by #28225
Assignees
Labels
P2 Important issue, but not time-critical ray-team-created Ray Team created tune Tune-related issues
Milestone

Comments

@Yard1
Copy link
Member

Yard1 commented Jul 14, 2022

What happened + What you expected to happen

Tune unit tests concerning SigOpt searcher are currently skipped in CI (in code) and the docs notebook (//doc/source/tune/examples:sigopt_example) is excluded from CI explicitly. This is due to the missing SigOpt API key in the CI environments. Anyscale has its own API key, and we would like to use it without leaking it. One way to do it would be to run the tests & notebook only for branch builds, like wandb and comet tests.

Versions / Dependencies

master

Reproduction script

Issue Severity

Low: It annoys or frustrates me.

@Yard1 Yard1 added bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks tune Tune-related issues air labels Jul 14, 2022
@Yard1 Yard1 added this to the Ray AIR milestone Jul 14, 2022
@richardliaw
Copy link
Contributor

Can you pass it in via the buildkite UI? cc @simon-mo

@simon-mo
Copy link
Contributor

No. The secrets must be injected through our CI infra manually. Release tests is the easiest way to put in such secret; CI build it a bit tough

@richardliaw richardliaw added P2 Important issue, but not time-critical and removed bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks labels Jul 25, 2022
@richardliaw richardliaw added the ray-team-created Ray Team created label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Important issue, but not time-critical ray-team-created Ray Team created tune Tune-related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants