Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[air] Improvements to XGBoost Benchmarking script #26612

Closed
richardliaw opened this issue Jul 15, 2022 · 0 comments
Closed

[air] Improvements to XGBoost Benchmarking script #26612

richardliaw opened this issue Jul 15, 2022 · 0 comments
Assignees
Labels
enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks

Comments

@richardliaw
Copy link
Contributor

  • Could we have separate scripts for training and prediction? This is for readability: it's not great to have multiple workflows in the same script.
  • Should make @run_and_time_it a common util
  • to_air_checkpoint(".", model) <--- isn't the "." fishy?
  • batch_predictor.predict(ds.drop_columns(["labels"])) <--- I think you can use the "feature_columns" arg of predict() that Amog added, instead of dropping labels.

Originally posted by @ericl in #26608 (review)

@richardliaw richardliaw added the P2 Important issue, but not time-critical label Jul 15, 2022
@richardliaw richardliaw added enhancement Request for new feature and/or capability air labels Jul 15, 2022
@richardliaw richardliaw added this to the Ray AIR milestone Jul 15, 2022
@richardliaw richardliaw changed the title Improvements to XGBoost Benchmarking script [air] Improvements to XGBoost Benchmarking script Jul 15, 2022
@ericl ericl added P1 Issue that should be fixed within a few weeks and removed P2 Important issue, but not time-critical labels Jul 15, 2022
@richardliaw richardliaw modified the milestones: Ray AIR, Ray 2.1, Ray 2.2 Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for new feature and/or capability P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

No branches or pull requests

4 participants