Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Widen grpcio dependency range #28354

Closed
chhabrakadabra opened this issue Sep 7, 2022 · 3 comments
Closed

[Core] Widen grpcio dependency range #28354

chhabrakadabra opened this issue Sep 7, 2022 · 3 comments
Assignees
@cadedaniel
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P0 Issues that should be fixed in short order

Comments

@chhabrakadabra
Copy link

Description

The current upper-bound for grpcio version is 1.43.0. I would really appreciate it if it could be raised to the latest version.

Use case

I'm trying to install Ray alongside Feast. The lower-bound for grpcio versions in Feast is set to 1.47.0, which makes it impossible to install alongside Ray.
@chhabrakadabra chhabrakadabra added the enhancement Request for new feature and/or capability label Sep 7, 2022
@cadedaniel
Copy link
Member

Thanks for creating this issue! I'm working on widening the grpcio dependency range this sprint, there was a hang in 1.48.0 but it has since been fixed in 1.48.1. #27299 for context.

@jjyao jjyao added core Issues that should be addressed in Ray Core P0 Issues that should be fixed in short order labels Sep 7, 2022
@h-vetinari
Copy link

h-vetinari commented Sep 8, 2022 •
edited
Loading

It would be really good to know which grpc-versions are affected by the hang. As I commented in #27299, we have to consider widening the range for conda-forge already, and I'd very much like to avoid hitting the hang.

In particular, it would be relevant for us to know if the hang appears with 1.46 / 1.47 (don't really care about older versions anymore); no problem to avoid 1.48.0 specifically.

@h-vetinari h-vetinari mentioned this issue Sep 8, 2022
Merged
@cadedaniel
Copy link
Member

I haven't tested it, but AFAIK the hang is only on 1.48.0. I'll make a PR to enable 1.45/46/47 and test to make sure there are no hangs.

@h-vetinari h-vetinari mentioned this issue Sep 23, 2022
Merged
@scv119 scv119 closed this as completed Sep 26, 2022
@h-vetinari h-vetinari mentioned this issue Nov 8, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cadedaniel cadedaniel

Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P0 Issues that should be fixed in short order
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chhabrakadabra @scv119 @jjyao @cadedaniel @h-vetinari