Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune] [Docs] Checkpointing example resume functionality is misleading #28722

Closed
justinvyu opened this issue Sep 22, 2022 · 0 comments · Fixed by #29411
Closed

[Tune] [Docs] Checkpointing example resume functionality is misleading #28722

justinvyu opened this issue Sep 22, 2022 · 0 comments · Fixed by #29411
Assignees
Labels
docs An issue or change related to documentation ray-team-created Ray Team created tune Tune-related issues

Comments

@justinvyu
Copy link
Contributor

Description

This example doesn't seem to actually resume the experiment as one of the comments suggest:

# if this experiment exists, we will resume from the last run
# as specified by
name="my-tune-exp",

Recreating a Tuner(…) rather than going through Tuner.restore(...) currently never resumes (resume=False is being passed into tune.run -> TrialRunner), and there’s no way to pass in a resume config into Tuner.

The old docs had the same example, and the code here does work because it manually passed in resume="AUTO", but this is not configured in the current broken example with the new 2.0 API.

In summary, the only way to resume a Tune experiment is through Tuner.restore right now, and the docs should not imply that there is another way. This makes it so that a change in your run script is needed to resume from an errored experiment (i.e. changing tuner = Tuner(...) to tuner = Tuner.restore(exp_path, resume_errored=True)).

Link

https://docs.ray.io/en/master/tune/tutorials/tune-checkpoints.html#a-simple-cloud-checkpointing-example

@justinvyu justinvyu added the docs An issue or change related to documentation label Sep 22, 2022
@richardliaw richardliaw added this to the Ray 2.2 milestone Oct 1, 2022
@justinvyu justinvyu self-assigned this Oct 28, 2022
@richardliaw richardliaw added the ray-team-created Ray Team created label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation ray-team-created Ray Team created tune Tune-related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants