-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][state] Microbench regression with task backend investigation #31546
Comments
With the current microbenchmark setup, we will start as many workers as possible, and thus multi threads on a single CoreWorker process (driver/worker) will actually contend for physical CPUs. With less Also, given the speciality of the microbenchmark (large number of no-op tasks), the owner is actually the bottleneck, which is different from many of the more realistic workloads, e.g. Could we close this since the root cause is identified (thread contention among workers) and the impact to more realistic workload is low? |
This sgtm. What do you think @scv119 ? |
Actually I am curious if we restrict the # of task event we can report per second, it will get better. Maybe we can experiment with 1000 tasks/s max batch after we merge the batch PR? |
Not a release blocker - mainly needs some experimentation and further validation. |
What happened + What you expected to happen
Investigate further if we could resolve the regression or identify the root cause (which function call/callsite causes this)
Versions / Dependencies
master
Reproduction script
NA
Issue Severity
None
The text was updated successfully, but these errors were encountered: