-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][KubeRay] Redirect the Ray docs on Kubernetes deployment to the up-to-date KubeRay docs #31694
Comments
Any thoughts? Thanks! cc. @DmitriGekhtman @architkulkarni @Jeffwan |
cc @jiwq |
Our philosophy here has been to make sure the Ray docs have full information for users to use Kuberay, and everything there should be consistent with current stable release of Kuberay that is referred to from the Ray docs. A Kuberay user should never have go to the Kuberay docs. This is to make sure we can have the same standard for using Kuberay as we have for the rest of the Ray documentation and a consistent experience. The Kuberay docs are for more advanced developer information / technical documentation. Users of Kuberay should not need it. It is possible that there is a better philosophy here going forward / this can be improved, I just want to point out why things are organized the way they are :) |
We are Ray users, but we have to visit the kuberay docs, because we do not use I don't know how many kuberay users there are like us, but just the migration from ray 1.x.x to 2.x.x has been a bit confusing due to discrepancies between the different versions of kuberay docs. It was hard to estimate how much time it would take to migrate. |
@mihajenko I'm curious why the Ray docs didn't work for you / what it has to do with I also wanted to point out that in order for the above philosophy to work, we need to make sure that the Ray docs really only refer to the latest stable KubeRay release -- e.g. at the moment there are references to |
(just for clarity, the Ray docs I'm referring to are https://docs.ray.io/en/latest/cluster/kubernetes/index.html) |
@pcmoritz RayService is documented as the prefered resource in the Ray Serve section of the Ray docs. We had to do some discovery to realize we can ignore that part of the documentation. |
@pcmoritz This philosophy can make sure every example in (3) works. However, as I mentioned in Example 1 and Example 2, some users deploy the KubeRay operator via (3) and want to explore other features in (1) and (2). Note:
Is there any method to avoid these examples? |
If we want to maintain the existing philosophy, one way to avoid those examples is the following: In the Kuberay docs, add disclaimers like "this example is supported from Kuberay 0.4.0 on; please ensure your KubeRay operator was deployed with version >0.4.0". (For nightly, we can write 0.5.0.) This is similar to what we do for new Ray features. The downside is this could be verbose, and we'd need to manually enforce adding these disclaimers for every new feature/example which could be hard. |
Documenting version requirements is important. We should explain that the RayService feature is recommended but not required to run Ray Serve on Kubernetes. Philipp's suggestion of placing the most basic and important bits in the Ray docs and more advanced stuff in the KubeRay docs makes sense. We could also consider versioning the KubeRay docs. |
Other points we discussed --
|
|
Broadly, yep, we need to keep the two doc pages consistent. (Literally unifying the two doc sites would be harder.) It could help to version the KubeRay docs, so that people see the latest KubeRay release's docs by default. This would be consistent with our handling of the Ray docs. (Currently the KubeRay doc page is built from the KubeRay master branch.) |
Description
Currently, we maintain KubeRay documents in both the KubeRay repository and the Ray repository. However, Ray docs on https://docs.ray.io/en/latest/ are only updated with new Ray releases. To summarize, users may access three different versions documents of KubeRay.
I take some bugs caused by the time difference between the three document sources as examples.
Example 1: [Feature] Make head serviceType optional kuberay#851 (comment)
Example 2: A user deploys KubeRay operator 0.3.0 via (3) and tries [autoscaler] Expose autoscaler container security context. kuberay#752 which starts to be supported by 0.4.0.
[Proposed solution]:
Link
No response
The text was updated successfully, but these errors were encountered: